Messages in this thread | | | Date | Mon, 22 Sep 2014 00:45:38 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v2 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant |
| |
On Mon, Sep 22, 2014 at 12:43:32PM +0800, Zefan Li wrote: > Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags") > defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing > because it is used as bit number. Redefine it as decimal bit number. > > Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0. > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Acked-by: Kees Cook <keescook@chromium.org> > [ lizf: slightly modified subject and changelog ] > Signed-off-by: Zefan Li <lizefan@huawei.com>
All the patches look good to me. I can't say I'm a big fan of function defining macros but I don't have prettier alternatives either. Once Peter/Ingo acks the patches, I'll route them through cgroup/for-3.17-fixes.
Thanks.
-- tejun
| |