lkml.org 
[lkml]   [2014]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python
From
Date
On Mon, 2014-09-22 at 10:45 +0200, Valentin Rothberg wrote:
> On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote:
> > On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote:
> > > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
> > > 2) ./lib/Makefile: TEST_MODULE (defined in lib/Kconfig.debug)
> >
> > TEST_MODULE is an awkward name for a Kconfig symbol. My local script has
> > it special cased.
>
> I plan to rename this feature in a future patch, since imho it violates
> the _MODULE suffix for kernel modules.

Probably a good idea. Could you please CC me if you actually do that?

> > > > > +REGEX_FILE_SOURCE = re.compile(r"\.[cSh]$")
> >
> > New observation: this causes the script to skip text files, shell
> > scripts, etc, doesn't it?
>
> Yes. Do you prefer to cover such files?

It seems useful. By now I must have pointed out stale, misspelled, or
simply odd references to Kconfig macros in Documentation and other
non-code files dozens of times. Documentation seems often overlooked
when Kconfig symbols change.

> I just grepped CONFIG_ in
> Documentation and think that covering such could improve the quality
> there too. I will put this into the next version of the patch.

You'll have to think about what to do with defconfig files. (I ignore
them in my local script, but you may want to report oddities in those
too. They are almost all outdated in one way or another.)

Hope this helps,


Paul Bolle



\
 
 \ /
  Last update: 2014-09-22 11:41    [W:0.046 / U:1.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site