lkml.org 
[lkml]   [2014]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] i2c: cadence: Remove .owner field for driver
    On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
    > There is no need to init .owner field.
    >
    > Based on the patch from Peter Griffin <peter.griffin@linaro.org>
    > "mmc: remove .owner field for drivers using module_platform_driver"
    >
    > This patch removes the superflous .owner field for drivers which

    It says drivers, but does only one...

    > use the module_platform_driver API, as this is overriden in
    > platform_driver_register anyway."

    ... so: any interest in doing this for the whole subsystem? Basically
    good catch, though.

    >
    > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
    > ---
    >
    > drivers/i2c/busses/i2c-cadence.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
    > index 63f3f03ecc9b..04d0a7e449ef 100644
    > --- a/drivers/i2c/busses/i2c-cadence.c
    > +++ b/drivers/i2c/busses/i2c-cadence.c
    > @@ -890,7 +890,6 @@ MODULE_DEVICE_TABLE(of, cdns_i2c_of_match);
    > static struct platform_driver cdns_i2c_drv = {
    > .driver = {
    > .name = DRIVER_NAME,
    > - .owner = THIS_MODULE,
    > .of_match_table = cdns_i2c_of_match,
    > .pm = &cdns_i2c_dev_pm_ops,
    > },
    > --
    > 1.8.2.3
    >


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-09-20 11:41    [W:5.793 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site