lkml.org 
[lkml]   [2014]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.
    On Tue, 02 Sep 2014 15:51:41 +0530
    Varka Bhadram <varkabhadram@gmail.com> wrote:

    > > + switch (((np == bitclkmaster) << 4) | (np == framemaster)) {
    > > + case 0x11:
    > > + return SND_SOC_DAIFMT_CBS_CFS;
    > > + case 0x10:
    > > + return SND_SOC_DAIFMT_CBS_CFM;
    > > + case 0x01:
    > > + return SND_SOC_DAIFMT_CBM_CFS;
    > > + default:
    > > + return SND_SOC_DAIFMT_CBM_CFM;
    > > + }
    > > +
    > > + /* Shouldn't be here */
    > > + return -EINVAL;
    > > +}
    >
    > It will be nice if we declare the switch case numbers as macros (specific name)...

    I don't see which macros: the values are just 2 booleans.

    --
    Ken ar c'hentañ | ** Breizh ha Linux atav! **
    Jef | http://moinejf.free.fr/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-09-02 13:21    [W:2.821 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site