lkml.org 
[lkml]   [2014]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [HPDD-discuss] [PATCH] staging: lustre: llite: Use kzalloc and rewrite null tests
With respect to the upper case lower case issue, does the thing need to be
a macro? I think that the lowercase is more or less fine, but only if
what is behind it is a function.

I say more or less fine, because normally in the kernel the special
allocators have special purposes, eg allocating and initializing the xyz
structure. Here what is wanted is a general purpose allocator with lots
of special tracing features, so it is not quite the same thing. And one
can wonder why all of these special tracing features are not relevant to
the kernel as a whole?

In reading through the description of the needed features, it seems like
only the _ptr extension requires being a macro. Do we need that? The
rest of the kernel manages to do x = kzalloc(sizeof(*x),...) ok. It's
unpleasant to have an assignment hidden in this way. And currently it is
not used consistently. There are some OBD_ALLOCs that have the same form.

Sorry for overlooking the frees. I was focusing on trying one thing at a
time...

julia


\
 
 \ /
  Last update: 2014-09-19 07:21    [W:0.068 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site