Messages in this thread | | | Date | Sat, 20 Sep 2014 01:44:41 +0200 | From | Radim Krčmář <> | Subject | Re: [PATCH] kvm: Make init_rmode_tss() return 0 on success. |
| |
2014-09-16 13:38+0200, Paolo Bonzini: > In init_rmode_tss(), there two variables indicating the return > value, r and ret, and it return 0 on error, 1 on success. The function > is only called by vmx_set_tss_addr(), and r is redundant. > > This patch removes the redundant variable, by making init_rmode_tss() > return 0 on success, -errno on failure.
Which is going to propagate all the way to userpace through ioctl ... is this change of A[PB]I acceptable?
Otherwise, -EFAULT seems to match unlikely problems better than -ENOMEM, so if it is acceptable: Reviewed-by: Radim Krčmář <rkrcmar@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |