lkml.org 
[lkml]   [2014]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH] rcu: Change use of __this_cpu ops on a bool type
On Fri, Sep 19, 2014 at 4:57 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Fri, Sep 19, 2014 at 01:26:03PM -0400, Pranith Kumar wrote:
>> __this_cpu_{read/write}() uses sizeof() to determine the size of the variable.
>> Using this operation on a bool type causes sparse to complain.
>>
>> I checked the generated code and there is only a slight difference in
>> instructions generated.
>>
>> I am not sure this warning by sparse is really valid, but let us silence it
>> anyways.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>
> I believe this warning was actually fixed with current versions of
> Sparse; there was some discussion and a patch on the linux-sparse
> mailing list. Can you please recheck with the latest Sparse from git,
> and if it still breaks, please raise that on linux-sparse?
>

Yup, looks like the latest version of sparse fixes this. Please ignore
this patch. Thanks!

--
Pranith


\
 
 \ /
  Last update: 2014-09-20 02:01    [W:0.037 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site