Messages in this thread | | | From | "Rustad, Mark D" <> | Subject | Re: [PATCH 7/7] sched: Silence nested-externs warnings | Date | Fri, 19 Sep 2014 20:49:53 +0000 |
| |
On Sep 19, 2014, at 1:41 PM, Richard Weinberger <richard@nod.at> wrote:
> Am 19.09.2014 22:34, schrieb Rustad, Mark D: >> Excellent. I'll try adding an include of delayacct.h instead. My patch was based on the assumption that the existing code was wanted in that form for some reason, so the patch served a purpose in recognizing that it isn't. So the macros have served a purpose before even being in place. :-) > > I bet sched.h does not include delayacct.h for a good reason. > sched.h is included in a lot of files, maybe delayacct.h introduces nasty dependency issues. > You'll find out. ;-)
Right you are, but when I'm done, there will only be one extern declaration for that global, which is better than more than one. I'll think a little before settling on the best resolution.
-- Mark Rustad, Networking Division, Intel Corporation
[unhandled content-type:application/pgp-signature] | |