lkml.org 
[lkml]   [2014]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node


On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote:
>
> [ added linux-kernel ML to cc: ]
>
> Hi,
>
> On Tuesday, August 26, 2014 11:19:59 AM dinguyen@opensource.altera.com wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Since the dwc2 hcd driver is currently not looking for a clock node during
>> init, we should not completely fail if there isn't a clock provided.
>> Add a check for a valid clock before calling clock functions.
>
> This doesn't look correct at least for the case when we are really missing
> the clock and USB_DWC2_PERIPHERAL=y (moreover it just looks wrong to access
> gadget functionalities when clock is disabled). It seems that it would be
> better to just disable gadget functionality on dwc2_gadget_init() failure
> in hcd and not call gadget functions later from hcd if gadget functionality
> is disabled.
>

Yes...this is correct. Will fix up in v5.

Thanks,
Dinh


\
 
 \ /
  Last update: 2014-09-19 17:01    [W:0.125 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site