lkml.org 
[lkml]   [2014]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP
Hi Chuck,

On 16/09/14 08:37, Chuck Ebbert wrote:
> static inline unsigned long *end_of_stack(struct task_struct *p)
> {
> +#ifdef CONFIG_STACK_GROWSUP
> + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1;

Nit: this line should probably be wrapped to 80 columns.

Other than that, I've tested this on metag and can confirm that it fixes
the following BUG which you would otherwise get during boot with Aaron's
patches:

BUG: failure at kernel/sched/core.c:2664/schedule_debug()!
Kernel panic - not syncing: BUG!

Tested-by: James Hogan <james.hogan@imgtec.com> [metag]
Acked-by: James Hogan <james.hogan@imgtec.com>

Aaron: please can you try to get this patch applied before your patch
series.

Thanks
James


\
 
 \ /
  Last update: 2014-09-19 14:01    [W:0.033 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site