lkml.org 
[lkml]   [2014]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit
On Thu, Sep 18, 2014 at 11:41:13AM +0200, Samuel Ortiz wrote:
> Hi Mika,
>
> On Thu, Sep 18, 2014 at 10:49:43AM +0300, Mika Westerberg wrote:
> > On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote:
> > > Direct Irq En bit can be initialized to a bad value.
> > > This bit has to be cleared for io access mode.
> >
> > +Eric
> >
> > I would like to have a bit better explanation *why* this bit needs to be
> > cleared.
> >
> > Also want to ask Eric (who added the WARN()), is there something
> > preventing us to do this? I remember last time you said that we are not
> > supposed to change this bit runtime.
> >
> > My preference is that we get rid of the WARN() and just unconditionally
> > clear the bit.
> I'd keep the warn though, as it most likely shows a buggy firmware
> implementation.

Fair enough :)

Maybe it could be more informative.


\
 
 \ /
  Last update: 2014-09-18 12:21    [W:0.067 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site