Messages in this thread | | | Date | Wed, 17 Sep 2014 19:46:47 +0200 | From | Oleg Nesterov <> | Subject | Re: [v2 PATCH 1/1] init: fix race between rootfs mount and firmware loading |
| |
On 09/17, Roman Pen wrote: > > +void wait_for_rootfs(void) > +{ > + /* Avoid waiting for ourselves */ > + if (is_global_init(current)) > + pr_warn("init: it is not a good idea to wait for the rootfs mount from the init task\n"); > + else > + wait_event(rootfs_waitq, rootfs_mounted); > +}
Well, this pr_warn() doesn't look very useful, how about
if (WARN_ON((is_global_init(current)))) return;
? this will show the caller.
> +static inline void wake_up_rootfs_waiters(void) > +{ > + rootfs_mounted = true; > + /* wake_up guarantees write memory barrier if and only if > + there is a task to be woken up, it is not always true > + for our case. */
Yes, but this doesn't matter. wait_event() takes care,
> + smp_wmb();
so please remove this wmb() and the comment.
Oleg.
| |