lkml.org 
[lkml]   [2014]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: thinkpad_acpi.c: fixed spacing coding style issue
On Wed, Sep 17, 2014 at 09:48:35AM -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 17 Sep 2014, Jan van den Berg wrote:
> > I will try and make _real_ contribution next time. (With this being my
> > first ever submission to the kernel: at least now I understand the kernel
> > workflow.)
>
> There's nothing wrong with your patch by itself. And git does try to help
> us take such patches (there's "git blame -w")... but ignoring whitespace
> changes doesn't always work as well as one would like.
>
> That said, Darren has already queued your patch, and I am _not_ going to ask
> him to drop it. So, as far as I'm concerned, the patch has been accepted,
> and that's it.

Henrique,

Thanks for the feedback. I had considered rejecting the patch for the reason you
describe, but opted to take it this time. I haven't established all my
maintainer policies yet, so they will change a little over time as we find what
works and what causes us more pain. Personally, I like to see the cleanups, but
generally agree that cleanups should typically be [PATCH 1/X] of a series.

Thanks,

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2014-09-17 19:01    [W:5.583 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site