Messages in this thread | | | Date | Wed, 17 Sep 2014 16:12:27 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 0/3] x86: structs for cpuid info in x86 |
| |
On Wed, Sep 17, 2014 at 02:37:10PM +0200, Ingo Molnar wrote: > If hpa, tglx or Linus objects I'll yield to that objection > though. > > Opinions, objections?
They generally look fine to me. I appreciate the bitfields for readability. I often use the same when having to deal with hardware bitfields. See for example the cpuid10_a?x unions in asm/perf_event.h
| |