lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 065/187] drm/tilcdc: panel: fix leak when unloading the module
    Date
    3.13.11.7 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Guido=20Mart=C3=ADnez?= <guido@vanguardiasur.com.ar>

    commit 3a49012224ca9016658a831a327ff6a7fe5bb4f9 upstream.

    The driver did not unregister the allocated framebuffer, which caused
    memory leaks (and memory manager WARNs) when unloading. Also, the
    framebuffer device under /dev still existed after unloading.

    Add a call to drm_fbdev_cma_fini when unloading the module to prevent
    both issues.

    Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
    Tested-by: Darren Etheridge <detheridge@ti.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    index 116da19..247ab5d 100644
    --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    @@ -122,6 +122,7 @@ static int tilcdc_unload(struct drm_device *dev)
    struct tilcdc_drm_private *priv = dev->dev_private;
    struct tilcdc_module *mod, *cur;

    + drm_fbdev_cma_fini(priv->fbdev);
    drm_kms_helper_poll_fini(dev);
    drm_mode_config_cleanup(dev);
    drm_vblank_cleanup(dev);
    --
    1.9.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-09-16 00:21    [W:3.942 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site