lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: "dma-coherent" property inheritance (arm vs arm64)
On 09/15/2014 11:52 AM, Catalin Marinas wrote:
> Hi Jon,
>
> On Sun, Sep 14, 2014 at 03:38:07AM +0100, Jon Masters wrote:
>> commit 6ecba8eb51b7d23fda66388a5420be7d8688b186
>> Author: Catalin Marinas <catalin.marinas@arm.com>
>> Date: Fri Apr 25 15:31:45 2014 +0100
>>
>> arm64: Use bus notifiers to set per-device coherent DMA ops
>>
>> Thus at this point, on 32-bit systems, we have defined this function:
>>
>> set_arch_dma_coherent_ops
>
> It was a timing issue that they are not in sync. I would have used
> set_arch_dma_coherent_ops() but it wasn't very clear when it gets merged
> and changing the default on arm64 broke some other assumptions, so a
> temporary fix.

Ok. So arm64 will automatically switch over to set_arch_dma_coherent_ops
(once it's there, it will be called automatically anyway because it's in
the callchain anyway already).

For the moment, on our internal PCI trees, we'll add a notifier and wait
for upstream to get PCI support and figure this out as part of that
activity. In the case of ACPI, I'm still pushing for _CCA methods to be
added by default because it makes sense to be verbose in describing
platform hardware devices, even in spite of default.

Jon.



\
 
 \ /
  Last update: 2014-09-15 19:01    [W:0.041 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site