Messages in this thread | | | Date | Mon, 15 Sep 2014 17:02:41 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang |
| |
On Mon, Sep 15, 2014 at 06:30:15AM +0100, behanw@converseincode.com wrote: > From: Mark Charlebois <charlebm@gmail.com> > > Remove '#' from immediate parameter in AARCH64 inline assembly in mmu. > > This code now works with both gcc and clang. > > Signed-off-by: Mark Charlebois <charlebm@gmail.com> > Signed-off-by: Behan Webster <behanw@converseincode.com> > --- > arch/arm64/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Thanks, Behan!
Catalin: please can you pick this up for 3.18? It's probably not worth me merging it as a fix, since there are other patches needed to get us building under clang anyway.
Will
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index c555672..6894ef3 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p) > */ > asm volatile( > " mrs %0, mair_el1\n" > - " bfi %0, %1, #%2, #8\n" > + " bfi %0, %1, %2, #8\n" > " msr mair_el1, %0\n" > " isb\n" > : "=&r" (tmp) > -- > 1.9.1 > >
| |