Messages in this thread | | | Date | Mon, 15 Sep 2014 16:56:56 +0100 | From | Will Deacon <> | Subject | Re: [PATCH 1/8] arm: Convert pr_warning to pr_warn |
| |
On Sat, Sep 13, 2014 at 07:31:12PM +0100, Joe Perches wrote: > Use the more common pr_warn. > > Other miscellanea: > > o Coalesce formats > o Realign arguments > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/arm/include/asm/syscall.h | 8 ++++---- > arch/arm/kernel/atags_parse.c | 2 +- > arch/arm/kernel/hw_breakpoint.c | 18 +++++++++--------- > arch/arm/kernel/irq.c | 4 ++-- > arch/arm/kernel/perf_event_cpu.c | 4 ++-- > arch/arm/kernel/smp.c | 2 +- > arch/arm/kernel/unwind.c | 24 ++++++++++++------------ > arch/arm/mm/idmap.c | 2 +- > arch/arm/mm/mmu.c | 4 ++-- > 9 files changed, 34 insertions(+), 34 deletions(-)
It's Russell's call on this, but it really looks like more trouble than it's worth imo. Having git blame identify the person who wrote the original code is considerably more useful than being pointed at somebody making cosmetic changes.
Will
| |