Messages in this thread | | | Date | Mon, 15 Sep 2014 19:41:23 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] drivers: char: hw_random: printk replacement |
| |
On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote: > as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Your patch doesn't even build:
CC [M] drivers/char/hw_random/intel-rng.o CC [M] drivers/char/hw_random/amd-rng.o CC [M] drivers/char/hw_random/via-rng.o drivers/char/hw_random/intel-rng.c: In function ‘intel_init_hw_struct’: drivers/char/hw_random/intel-rng.c:317:3: error: expected ‘)’ before ‘warning’ drivers/char/hw_random/intel-rng.c:308:36: warning: unused variable ‘warning’ [-Wunused-variable] make[1]: *** [drivers/char/hw_random/intel-rng.o] Error 1
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |