lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 058/187] ASoC: adau1701: fix adau1701_reg_read()
    Date
    3.13.11.7 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Daniel Mack <zonque@gmail.com>

    commit 3ad80b828b2533f37c221e2df155774efd6ed814 upstream.

    Fix a long standing bug in the read register routing of adau1701.
    The bytes arrive in the buffer in big-endian, so the result has to be
    shifted before and-ing the bytes in the loop.

    Signed-off-by: Daniel Mack <zonque@gmail.com>
    Acked-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Mark Brown <broonie@linaro.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/soc/codecs/adau1701.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
    index adee866..56bfc67 100644
    --- a/sound/soc/codecs/adau1701.c
    +++ b/sound/soc/codecs/adau1701.c
    @@ -230,8 +230,10 @@ static int adau1701_reg_read(void *context, unsigned int reg,

    *value = 0;

    - for (i = 0; i < size; i++)
    - *value |= recv_buf[i] << (i * 8);
    + for (i = 0; i < size; i++) {
    + *value <<= 8;
    + *value |= recv_buf[i];
    + }

    return 0;
    }
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-09-16 01:21    [W:4.025 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site