Messages in this thread | | | Date | Sat, 13 Sep 2014 09:37:49 -0700 | From | Mark Brown <> | Subject | Re: [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller |
| |
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
> +++ b/sound/soc/rockchip/rockchip_i2s.c > @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n"); > return PTR_ERR(i2s->hclk); > } > + ret = clk_prepare_enable(i2s->hclk); > + if (ret) { > + dev_err(i2s->dev, "hclock enable failed %d\n", ret); > + return ret; > + }
BTW: you're also missing a clk_disable_unprepare() in the remove path here, please send a followup fixing that. [unhandled content-type:application/pgp-signature] | |