lkml.org 
[lkml]   [2014]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller
    On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:

    > +++ b/sound/soc/rockchip/rockchip_i2s.c
    > @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
    > dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n");
    > return PTR_ERR(i2s->hclk);
    > }
    > + ret = clk_prepare_enable(i2s->hclk);
    > + if (ret) {
    > + dev_err(i2s->dev, "hclock enable failed %d\n", ret);
    > + return ret;
    > + }

    BTW: you're also missing a clk_disable_unprepare() in the remove path
    here, please send a followup fixing that.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-09-13 19:21    [W:2.147 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site