Messages in this thread | | | Subject | Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s | From | Maciej Matraszek <> | Date | Thu, 11 Sep 2014 19:02:58 +0200 |
| |
On Wed, 2014-09-10 at 11:27 -0700, Greg Kroah-Hartman wrote: > > > > > > > + if (!d) > > > > + return -ENOMEM; > > > > + > > > > + return 0; > > > > +} > > > > +late_initcall(pm_genpd_debug_init); > > > > +#endif /* CONFIG_PM_ADVANCED_DEBUG */ > > > > > > No tear-down of the debugfs files on shutdown? > > > > In drivers/clk/clk.c, there is no tear-down of debugfs files paired > > with clk_debug_init(), same with wakeup_sources_debugfs_init() from > > drivers/base/power/wakeup.c. On the other hand, some subsystems > > perform it. What would you prefer? > > In my quest for symmetry I prefer to see files you add to be removed at > the proper time. :)
And they will be! (in v2 :)
Thanks, -- Maciej Matraszek Samsung R&D Institute Poland Samsung Electronics
| |