Messages in this thread | | | Date | Thu, 11 Sep 2014 17:25:41 +0100 | From | Rob Jones <> | Subject | Re: [PATCH] fs: replace int param with size_t for seq_open_private() |
| |
On 01/09/14 16:36, Al Viro wrote: > On Mon, Sep 01, 2014 at 02:17:08PM +0100, Rob Jones wrote: > >> void *__seq_open_private(struct file *f, const struct seq_operations *ops, >> - int psize) >> + size_t psize) > > <sarcasm> > It is a horrible limitation to impose, indeed. Why, a lousy > 2 gigabytes per line in procfs file - that's intolerable... > </sarcasm> > >
OK, I know this is a trivial patch but I've gone away and thought about it and done some reading to see what the rest of the world thinks about using size_t vs unsigned int (signed int is an abomination in this context regardless).
I think Al's sarcasm is misplaced.
The correct type to use here *is* size_t. It's about consistency and, more importantly, it's about not making assumptions about the hardware architecture. It's included in the language for very good reasons and it seems to me to be risky to ignore those reasons.
I would like the patch to be considered for inclusion, it costs nothing and could avoid a future problem coming up to bite us in the bum.
-- Rob Jones Codethink Ltd mailto:rob.jones@codethink.co.uk tel:+44 161 236 5575
| |