Messages in this thread | | | Date | Thu, 11 Sep 2014 07:59:15 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH v8 09/10] x86, mpx: cleanup unused bound tables |
| |
On 09/11/2014 01:46 AM, Qiaowei Ren wrote: > + * This function will be called by do_munmap(), and the VMAs covering > + * the virtual address region start...end have already been split if > + * necessary and remvoed from the VMA list.
"remvoed" -> "removed"
> +void mpx_unmap(struct mm_struct *mm, > + unsigned long start, unsigned long end) > +{ > + int ret; > + > + ret = mpx_try_unmap(mm, start, end); > + if (ret == -EINVAL) > + force_sig(SIGSEGV, current); > +}
In the case of a fault during an unmap, this just ignores the situation and returns silently. Where is the code to retry the freeing operation outside of mmap_sem?
| |