lkml.org 
[lkml]   [2014]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V4] pwm: lpc32xx - Add a driver for the motor PWM
Date
On Thursday 11 September 2014 10:36:21 Alban Bedel wrote:
> On Wed, 10 Sep 2014 18:28:39 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Wednesday 10 September 2014 17:59:41 Alban Bedel wrote:
> > > On Wed, 10 Sep 2014 17:51:36 +0200
> > > Arnd Bergmann <arnd@arndb.de> wrote:
> > >
> > > > On Wednesday 10 September 2014 17:43:42 Alban Bedel wrote:
> > > > > +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of
> > > > > + the cells format. The only third cell flag supported by this binding is
> > > > > + PWM_POLARITY_INVERTED.
> > > >
> > > > If you don't have multiple pwm outputs or programmable period, I would say it
> > > > should use #pwm-cells=<1> and only pass the polarity.
> > >
> > > There is 3 channel, so 3 PWM from the API POV, and the period is
> > > independently programmable for each one.
> >
> > Then you should put the channel number into the first cell and the period
> > length into the second cell, as the pwm.txt document says.
>
> That's what is implemented in this patch, by using
> of_pwm_xlate_with_flags() for the .of_xlate callback.
>

Ah, my mistake. I misread the sentence in the binding for meaning that
you only support the third cell. It's all good then.

Arnd


\
 
 \ /
  Last update: 2014-09-11 12:21    [W:0.065 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site