Messages in this thread | | | Date | Wed, 10 Sep 2014 15:34:02 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context |
| |
On Wed, Sep 10, 2014 at 03:28:10PM -0400, Jeff Layton wrote: > Yes, that's the downside of moving to multiple list_heads. Still, I > think it's worth doing that even if we end up with the code a bit more > verbose. > > It may be best to consider moving some of this into helpers that live > in locks.c. I really don't like having filesystems poke around in the > intimate details of the file locking code as a general rule...
I was also wondering whether helpers like for_each_posix_lock() or first_posix_lock() would be worth it.
--b.
| |