Messages in this thread Patch in this message | | | From | Michal Nazarewicz <> | Subject | [PATCH 2/2] usb: f_fs: replace BUG in dead-code with less serious WARN_ON | Date | Wed, 10 Sep 2014 17:50:25 +0200 |
| |
Even though the BUG() in __ffs_event_add is a dead-code, it is still better to warn rather then crash the system if that code ever gets executed.
Suggested-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- This has been compile tested only.
drivers/usb/gadget/function/f_fs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index ec50e0d..74d48b3 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -2321,7 +2321,9 @@ static void __ffs_event_add(struct ffs_data *ffs, break; default: - BUG(); + pr_vdebug("%d: unknown event, this should not happen\n", type); + WARN_ON(1); + return; } { -- 2.1.0.rc2.206.gedb03e5
| |