lkml.org 
[lkml]   [2014]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 5/5] ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor
From
Javier,

On Wed, Aug 20, 2014 at 4:19 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The Exynos5420 based Peach Pit and the Exynos5800 based Peach Pi
> machines have an i2c ISL29018 light sensor. This patch adds the
> device nodes needed to support this device.
>
> These DTS snippets were taken from the downstream Chrome OS 3.8
> kernel Device Tree for Peach Pit and Pi boards.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 6 ++++++
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 ++++++
> 2 files changed, 12 insertions(+)

I would note that the downstream dts file has this i2c bus at 400kHz.
...but that's not a problem with your patch. Perhaps you could submit
that as a separate patch?

Reviewed-by: Doug Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2014-09-10 07:21    [W:0.143 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site