Messages in this thread | | | Subject | Re: [PATCH] sound: aoa: printk replacement | From | Johannes Berg <> | Date | Wed, 10 Sep 2014 15:57:04 +0200 |
| |
On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > as pr_* macros are more preffered over printk, so printk replaced > with corresponding pr_* macros.
Are you simply running checkpatch on every file and decided to do something about it? :)
I'll let Takashi decide whether to take this or not as I no longer care about this code, but IMHO this changes is completely pointless since you don't also clean up the code to have a common prefix with #define pr_fmt and then clean up the callers etc.
There's a reason pr_* is preferred, but random code changes like this aren't it, I think.
johannes
| |