lkml.org 
[lkml]   [2014]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 1/5] dt-bindings: Add RK808 device tree bindings document
    From
    Chris,

    On Mon, Sep 1, 2014 at 2:07 AM, Chris Zhong <zyw@rock-chips.com> wrote:
    > Add device tree bindings documentation and a header file
    > for rockchip's RK808 pmic.
    >
    > Signed-off-by: Chris Zhong <zyw@rock-chips.com>
    > Signed-off-by: Zhang Qing <zhangqing@rock-chips.com>
    >
    > ---
    >
    > Changes in v7:
    > Advices by Mark Rutland
    > - modify description about clock-cells
    > - update the example
    >
    > Changes in v6:
    > Advices by Mark Rutland
    > - add description about clock-cells
    > Advices by Doug
    > - modify description about regulator
    > - remove pinctrl description
    >
    > Changes in v5:
    > Advices by Mark Brown
    > - add description about regulator valid name.
    > - add a header file "rockchip,rk808".
    >
    > Changes in v4:
    > Advices by Doug
    > - add a "#clock-cells" propertiy
    > - update the example
    >
    > Changes in v3: None
    > Changes in v2: None
    >
    > Documentation/devicetree/bindings/mfd/rk808.txt | 166 +++++++++++++++++++++++
    > include/dt-bindings/clock/rockchip,rk808.h | 11 ++
    > 2 files changed, 177 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt
    > create mode 100644 include/dt-bindings/clock/rockchip,rk808.h
    >
    > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
    > new file mode 100644
    > index 0000000..f8932ac
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
    > @@ -0,0 +1,166 @@
    > +RK808 Power Management Integrated Circuit
    > +
    > +Required properties:
    > +- compatible: "rockchip,rk808"
    > +- reg: I2C slave address
    > +- interrupt-parent: The parent interrupt controller.
    > +- interrupts: the interrupt outputs of the controller.
    > +- #clock-cells: from common clock binding; shall be set to 1 (multiple clock
    > + outputs)

    I think Mark Rutland was looking for something like:

    - #clock-cells: from common clock binding; shall be set to 1 (multiple clock
    outputs). See <dt-bindings/clock/rockchip,rk808.h> for clock IDs.


    > +Optional properties:
    > +- clock-output-names: From common clock binding to override the
    > + default output clock name
    > +- rockchip,system-power-controller: Telling whether or not this pmic is controlling
    > + the system power.
    > +
    > +Regulators: All the regulators of RK808 to be instantiated shall be
    > +listed in a child node named 'regulators'. Each regulator is represented
    > +by a child node of the 'regulators' node.
    > +
    > + regulator-name {
    > + /* standard regulator bindings here */
    > + };
    > +
    > +Following regulators of the RK808 PMIC block are supported. Note that
    > +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
    > +number as described in RK808 datasheet.
    > +
    > + - DCDC_REGn
    > + - valid values for n are 1 to 4.
    > + - LDO_REGn
    > + - valid values for n are 1 to 8.
    > + - SWITCH_REGn
    > + - valid values for n are 1 to 2
    > +
    > +Standard regulator bindings are used inside regulator subnodes. Check
    > + Documentation/devicetree/bindings/regulator/regulator.txt
    > +for more details
    > +
    > +Example:
    > + rk808: pmic@1b {
    > + compatible = "rockchip,rk808";
    > + clock-output-names = "xin32k", "rk808-clkout2";
    > + interrupt-parent = <&gpio0>;
    > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
    > + pinctrl-names = "default";
    > + pinctrl-0 = <&pmic_int>;
    > + reg = <0x1b>;
    > + rockchip,system-power-controller;
    > + wakeup-source;
    > + #clock-cells = <1>;
    > +
    > + vcc8-supply = <&vcc_18>;
    > + vcc9-supply = <&vcc_io>;
    > + vcc10-supply = <&vcc_io>;
    > + vcc12-supply = <&vcc_io>;
    > + vddio-supply = <&vccio_pmu>;

    Technically the "-supply" section shouldn't be here. I plan to add
    support for input supplies once you've landed your series. See
    <https://chromium-review.googlesource.com/#/c/214596/> for a preview.
    Just leave the "-supply" section out for now.

    Other than that, this looks great.

    Reviewed-by: Doug Anderson <dianders@chromium.org>


    \
     
     \ /
      Last update: 2014-09-02 06:21    [W:2.356 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site