lkml.org 
[lkml]   [2014]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] iio: accel: BMC150: fix issues when CONFIG_PM_RUNTIME is not set
On Sat, Aug 30, 2014 at 11:45:33AM +0100, Jonathan Cameron wrote:
> On 29/08/14 09:38, Laurentiu Palcu wrote:
> > When CONFIG_PM_RUNTIME is not set, the following issues are seen:
> > * warning message at compilation time:
> > warning: 'bmc150_accel_get_startup_times' defined but not used [-Wunused-function]
> > * bmc150_accel_set_power_state() will always fail and reading the
> > accelerometer data is impossible;
> Why? Would be good to have an explanation here...
>
> If on is true then it will call pm_runtime_get_sync which calls __pm_runtime_resume
> which when CONFIG_PM_RUNTIME is not defined returns 1 which is not an error.
>
> In the on = false case it calls pm_runtime_put_autosuspend which calls __pm_runtime_suspend
> which returns -ENOSYS and gives our error.
>
> I'll add something to the patch description to this effect.
Thank you! I'll try to better describe my changes next time.

laurentiu


\
 
 \ /
  Last update: 2014-09-01 11:41    [W:0.106 / U:3.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site