Messages in this thread | | | Date | Sat, 9 Aug 2014 17:47:24 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] staging: nokia_h4: merge firmware together so that we can reduce ammount of exports |
| |
Hi!
> > + > > + skb_queue_tail(&info->txq, fw_skb); > > + spin_lock_irqsave(&info->lock, flags); > > + hci_h4p_outb(info, UART_IER, hci_h4p_inb(info, UART_IER) | > > + UART_IER_THRI); > > + spin_unlock_irqrestore(&info->lock, flags); > > +} > > and as I explained before, this crazy can not continue. Bluetooth drivers can provide a hdev->setup callback for loading firmware and doing other setup details. You can just bring up the HCI transport. We are providing __hci_cmd_sync for easy loading of the firmware. Especially if the firmware just consists of HCI commands. Which is clearly the case with the Nokia firmware files. >
I know that this crazyness can not continue; but I need to be able to move "bad" code around to get the cleanups, ok? Because you also asked me to reduce ammount of exports.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |