lkml.org 
[lkml]   [2014]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests
On Thu, Aug 07, 2014 at 01:07:46PM -0600, Shuah Khan wrote:
> Add a new make target "kselftest" to enable kernel testing. This
> new target builds and runs kernel selftests. Running as root is
> recommended for a complete test run as some tests don't run when
> run by non-root user. Build, install, and boot kernel before
> running kselftest on it.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> Makefile | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index d0901b4..574e8da 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1036,6 +1036,13 @@ headers_check: headers_install
> $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>
> # ---------------------------------------------------------------------------
> +# Kernel selftest
> +
> +PHONY += kselftest
> +kselftest:
> + $(Q)$(MAKE) -C tools/testing/selftests run_tests
> +
> +# ---------------------------------------------------------------------------
> # Modules
>
> ifdef CONFIG_MODULES
> @@ -1238,6 +1245,11 @@ help:
> @echo ' headerdep - Detect inclusion cycles in headers'
> @$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> @echo ''
> + @echo 'Kernel selftest'
> + @echo ' kselftest - Build and run kernel selftest (run as root)'
> + @echo ' Build, install, and boot kernel before'
> + @echo ' running kselftest on it'
It is never good to advertise to run something as root.
But I see that this is recommended for now so the patch has my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Sam



\
 
 \ /
  Last update: 2014-08-07 23:01    [W:0.042 / U:2.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site