lkml.org 
[lkml]   [2014]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scsi: Check if WSR already defined
On 08/07/2014 07:38 AM, Nick Krause wrote:
> On xtensa arch there is this warning
>
> drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by default]
> arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition
>
> I can remove WSR since it is not being used but more documentation purpose, so
> undefining is enough.
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/scsi/sym53c8xx_2/sym_defs.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_defs.h b/drivers/scsi/sym53c8xx_2/sym_defs.h
> index defccc4..68334a5 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_defs.h
> +++ b/drivers/scsi/sym53c8xx_2/sym_defs.h
> @@ -91,6 +91,10 @@ struct sym_chip {
> #define FE_CACHE0_SET (FE_CACHE_SET & ~FE_ERL)
> };
>
> +#ifdef WSR
> +#undef WSR
> +#endif
> +
> /*
> * SYM53C8XX IO register data structure.
> */
>
Ouch.
Certainly not. Who knows for which odd function the 'WSR' definition
is used.
Better to redefine WSR in sym_defs.h.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-08-07 15:21    [W:0.036 / U:1.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site