lkml.org 
[lkml]   [2014]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()


On 07/24/2014 09:19 AM, Andrew Morton wrote:
>
> So what should rtc do in this case? At present it pretends the read
> succeeded. Either way, this doesn't seem to be the place to be making
> such policy decisions..
>
>
>

I agree. But, in this case, RTC device driver can not do anything. And if
rtc_suspend() returns a minus value, then suspend will be aborted. So,
in the worst case, suspend will be failed continually. I think this is not
good.

Most RTC device drivers don't verify the read time value. Even some drivers
just return '0' value(omap, tegra, ...). So, I think the higher level
framework like /drivers/rtc/interface.c should check and handle the rtc
read time.


\
 
 \ /
  Last update: 2014-08-07 04:21    [W:0.071 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site