Messages in this thread | | | From | (Eric W. Biederman) | Date | Wed, 06 Aug 2014 18:03:32 -0700 | Subject | Re: [PATCH] seq_file: Allow private data to be supplied on seq_open |
| |
Al Viro <viro@ZenIV.linux.org.uk> writes:
> On Wed, Aug 06, 2014 at 05:16:49PM +0100, Rob Jones wrote: > >> I'm not quite sure I understand your meaning when you say "via seq_open" >> though, that function call format needs to stay the same or lots of >> code will break, so I can't just add the third parameter on the end. >> (C++ does have *some* advantages!) Can you clarify, please? > > seq_open_private() can be implemented as call of seq_open() + > assignment...
This is why I object to the name seq_open_priv() for the new code. seq_open_private() is already implemented and base on seq_open().
And the names are close enough together it is confusing :(
Eric
| |