Messages in this thread | | | From | "Keller, Jacob E" <> | Subject | Re: [E1000-devel] PROBLEM: [x86] Running ptpd2 using an Intel 82572EI (e1000e) leads to a kernel oops (3.12.26) | Date | Wed, 6 Aug 2014 22:32:56 +0000 |
| |
On Wed, 2014-08-06 at 15:38 +0000, Fujinaka, Todd wrote: > Looking at your patches on netdev, it appears that there are flags set in the skb that should never be set for the 82572EI as that part doesn't have hardware timestamping. This points to a bug in the ptpd code. > > Todd Fujinaka > Software Application Engineer > Networking Division (ND) > Intel Corporation > todd.fujinaka@intel.com > (503) 712-4565
Surely we can bail here instead of generating a kernel oops? Even though ptpd may be incorrect here, we still shouldn't do this. I think this may be a bug in the set_ts_config possibly as well (since it shouldn't be able to set the hardware timestamp flags for the 82572EI
Thanks, Jake
| |