Messages in this thread | | | Date | Wed, 6 Aug 2014 21:12:36 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support |
| |
On Wed, Aug 06, 2014 at 10:42:37AM +0800, Nicolin Chen wrote: > On Tue, Aug 05, 2014 at 04:44:29PM +0530, Varka Bhadram wrote:
> > Reading comfortably is important for us... :-) > > see this:http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt#L46
> I know how to write a binding doc with indentations to make it clear.
> What I'm talking about is that the doc was created without indentations, > so I don't feel comfortable to add indentations starting from this patch > while leaving the old lines in totally a different style because It's not > helpful to make people read comfortably at all but only forcing people to > think why these two lines are so special to take some steps back here.
> So personally I agree with your idea to make doc more readable. But what > I prefer to do is not having a conversation on the style within this patch > but to create an extra style-refinement patch later after this one.
This is the right approach. [unhandled content-type:application/pgp-signature] | |