lkml.org 
[lkml]   [2014]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread
> Hi Eric,
>
> I've not had a chance to test these, but apart from two trivial
> comments below these look good to me, and I appreciate the feature.
> So with the two fixes (if needed),
>
> Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

>> +static int proc_thread_self_readlink(struct dentry *dentry, char __user *buffer,
>> + int buflen)
>> +{
>> + struct pid_namespace *ns = dentry->d_sb->s_fs_info;
>> + pid_t tgid = task_tgid_nr_ns(current, ns);
>> + pid_t pid = task_pid_nr_ns(current, ns);
>> + char tmp[PROC_NUMBUF + 6 + PROC_NUMBUF];
>
> In the extreme case you're not adding space for a \0 ? (Unless
> PROC_NUMBUF includes that)

PROC_NUMBUF has enough space for a sign for the maximum of 10 digits
for a newline and a terminating \0. So yes PROC_NUMBUF includes the
space for a terminating \0.

Eric


\
 
 \ /
  Last update: 2014-08-06 20:41    [W:0.036 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site