Messages in this thread | | | Date | Wed, 6 Aug 2014 18:06:52 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline during S3 |
| |
Hi,
On Wed, Aug 06, 2014 at 01:13:21PM +0000, Lan, Tianyu wrote: > Have you tried my attached kernel config file? When someone reported > the issue to me, I also was very hard to reproduce the issue by my > own config file. Maybe once 100 tries. But I can reproduced the issue > every time with the attached configure file on several my machines and > even on server.
first of all, please do not top-post:
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Now, it looks like the issue is timing-related, depending on when we're going to see CPU_DEAD, before or after the msleep. Thus, if some distro config runs more crap on the suspend path and we don't see the CPU_DEAD before we sleep for 100ms, then we get to wait at least once and it shows in the suspend trace.
So, using the completion timeout seems like a net improvement for such configs and thus for any config.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |