lkml.org 
[lkml]   [2014]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support
    Date
    On Wed, Aug 6, 2014, at 11:30, Sergei Shtylyov wrote:
    > On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote:
    >
    > > With the Intel 82527EI (driver: e1000e) there is an issue when running
    > > the ptpd2 program, that leads to a kernel oops.
    > > The reason is here that in e1000_xmit_frame() a work queue will be
    > > scheduled that has not been initialized in this case.
    > > The work queue "tx_hwstamp_work" will only be initialized if
    > > adapter->flags & FLAG_HAS_HW_TIMESTAMP set.
    > > This check is missing in e1000_xmit_frame().
    >
    > > The following patch adds the missing check.
    >
    > OK, but this time you forgot your sign-off. :-)

    Also, shouldn't the added test be inside the unlikely() ?

    --
    "One disk to rule them all, One disk to find them. One disk to bring
    them all and in the darkness grind them. In the Land of Redmond
    where the shadows lie." -- The Silicon Valley Tarot
    Henrique Holschuh


    \
     
     \ /
      Last update: 2014-08-06 17:41    [W:2.981 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site