lkml.org 
[lkml]   [2014]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2] i2c: i2c-imx: Fix format warning for dev_dbg
Date
On Wednesday, August 06, 2014 12:45 PM, Xiubo Li wrote:

The subject of the commit looks too general.
How about the following?

i2c: i2c-imx: Use printf extension %pR for struct resource

Best regards,
Jingoo Han

>
> drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe()
> drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument
> of type unsigned int, but argument 4 has type resource_size_t [-Wformat=]
> dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n",
> ^
> drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument
> of type unsigned int, but argument 5 has type resource_size_t [-Wformat=]
>
> drivers/i2c/busses/i2c-imx.c:691:2: warning: format %d expects argument
> of type int, but argument 4 has type resource_size_t [-Wformat=]
> dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n",
> ^
> drivers/i2c/busses/i2c-imx.c:691:2: warning: format 0x%x expects argument
> of type unsigned int, but argument 5 has type resource_size_t [-Wformat=]
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>
> Change in v2:
> - Follow Joe Perches's advice.
>
>
>
>
>
> drivers/i2c/busses/i2c-imx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 1d7efa3..b8a9543 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -686,10 +686,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> clk_disable_unprepare(i2c_imx->clk);
>
> dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq);
> - dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n",
> - res->start, res->end);
> - dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n",
> - resource_size(res), res->start);
> + dev_dbg(&i2c_imx->adapter.dev, "device resources: %pR\n", res);
> dev_dbg(&i2c_imx->adapter.dev, "adapter name: \"%s\"\n",
> i2c_imx->adapter.name);
> dev_info(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
> --
> 1.8.5



\
 
 \ /
  Last update: 2014-08-06 06:41    [W:0.042 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site