Messages in this thread | | | From | Yann Droneaud <> | Date | Wed, 06 Aug 2014 12:00:00 +0200 | Subject | Re: [PATCH] perf tools: Fix PERF_FLAG_FD_CLOEXEC flag probing event type open counters due to EBUSY error |
| |
Hi,
Le dimanche 03 août 2014 à 14:10 +0200, Jiri Olsa a écrit : > On Sat, Aug 02, 2014 at 07:58:25PM +0200, Yann Droneaud wrote:
> heh, I haven't realized that your probing event was > PERF_COUNT_SW_CPU_CLOCK, which could never be busy > and found following bug ;-) > > jirka > > > --- > We were using PERF_COUNT_SW_CPU_CLOCK as an probing event type. > Using expected PERF_TYPE_SOFTWARE type instead. > > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: David Ahern <dsahern@gmail.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Namhyung Kim <namhyung@gmail.com> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Stephane Eranian <eranian@google.com> > Cc: William Cohen <wcohen@redhat.com> > Cc: Yann Droneaud <ydroneaud@opteya.com> > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/util/cloexec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cloexec.c b/tools/perf/util/cloexec.c > index dc360ebde745..0f7eb0a53d4b 100644 > --- a/tools/perf/util/cloexec.c > +++ b/tools/perf/util/cloexec.c > @@ -9,7 +9,7 @@ static int perf_flag_probe(void) > { > /* use 'safest' configuration as used in perf_evsel__fallback() */ > struct perf_event_attr attr = { > - .type = PERF_COUNT_SW_CPU_CLOCK, > + .type = PERF_TYPE_SOFTWARE, > .config = PERF_COUNT_SW_CPU_CLOCK,
erf ... I was even not able to copy paste correctly the configuration used in perf_evsel__fallback(), my bad.
Thanks for the fix.
Regards.
-- Yann Droneaud OPTEYA
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |