Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2] arch,locking: Ciao arch_mutex_cpu_relax() | From | Davidlohr Bueso <> | Date | Tue, 05 Aug 2014 10:42:19 -0700 |
| |
On Tue, 2014-08-05 at 15:04 +0200, Geert Uytterhoeven wrote: > It looks like you forgot to update frv? It's been failing on -next since a > few days: > > kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of > function 'cpu_relax_lowlatency' > [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of > function 'cpu_relax_lowlatency' > [-Werror=implicit-function-declaration] > make[3]: *** [kernel/locking/mcs_spinlock.o] Error 1 > cc1: some warnings being treated as errors > make[3]: *** [kernel/locking/mutex.o] Error 1 > > http://kisskb.ellerman.id.au/kisskb/buildresult/11616307/
Ah, indeed. Thanks for the report, afaict this was the only missing arch .
8<--------------------------------------------------------------- From: Davidlohr Bueso <davidlohr@hp.com> Subject: [PATCH] frv: Define cpu_relax_lowlatency()
Fixes errors such as:
kernel/locking/mcs_spinlock.h:87:2: error: implicit declaration of function 'cpu_relax_lowlatency'
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Davidlohr Bueso <davidlohr@hp.com> --- arch/frv/include/asm/processor.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/frv/include/asm/processor.h b/arch/frv/include/asm/processor.h index a34f309..6554e78 100644 --- a/arch/frv/include/asm/processor.h +++ b/arch/frv/include/asm/processor.h @@ -129,7 +129,8 @@ unsigned long get_wchan(struct task_struct *p); #define KSTK_EIP(tsk) ((tsk)->thread.frame0->pc) #define KSTK_ESP(tsk) ((tsk)->thread.frame0->sp) -#define cpu_relax() barrier() +#define cpu_relax() barrier() +#define cpu_relax_lowlatency() cpu_relax() /* data cache prefetch */ #define ARCH_HAS_PREFETCH -- 1.8.1.4
| |