Messages in this thread | | | Date | Mon, 4 Aug 2014 14:48:23 -0700 | From | Greg KH <> | Subject | Re: [PATCH] tty: serial: msm: fix checkpatch warnings |
| |
On Mon, Aug 04, 2014 at 02:42:02PM -0700, Frank Rowand wrote: > On 8/4/2014 7:20 AM, Kiran Padwal wrote: > > This patch fixes the following checkpatch.pl warning: > > > > WARNING: braces {} are not necessary for any arm of this statement > > > > WARNING: Missing a blank line after declarations > > > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > > > WARNING: else is not generally useful after a break or return > > > > WARNING: void function return statements are not generally useful > > > > Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com> > > --- > > drivers/tty/serial/msm_serial.c | 26 +++++++++++--------------- > > 1 file changed, 11 insertions(+), 15 deletions(-) > > Kiran, > > I have a series of fix patches against this file that is going to collide > with your cleanups. Would you mind waiting until after I send my patches > to do your clean up?
It's a first-come-first served, never ask someone to wait for you to send your patches, you can't 'lock' a file in the kernel from changes from others, that way is the death of a project.
So no, Kiran, don't wait :)
thanks,
greg k-h
| |