Messages in this thread | | | Date | Sun, 31 Aug 2014 10:23:46 -0700 | From | Olof Johansson <> | Subject | Re: [PATCH] vexpress/spc: fix a build warning on array bounds |
| |
On Thu, Aug 28, 2014 at 09:00:59PM -0700, Pawel Moll wrote: > On pi??, 2014-08-29 at 02:45 +0100, Alex Shi wrote: > > On 07/16/2014 07:28 PM, Sudeep Holla wrote: > > > > > > > > > On 16/07/14 12:21, Alex Shi wrote: > > >> With ARCH_VEXPRESS_SPC option, kernel build has the following > > >> warning: > > >> > > >> arch/arm/mach-vexpress/spc.c: In function ???ve_spc_clk_init???: > > >> arch/arm/mach-vexpress/spc.c:431:38: warning: array subscript is below > > >> array bounds [-Warray-bounds] > > >> struct ve_spc_opp *opps = info->opps[cluster]; > > >> ^ > > >> since 'cluster' maybe '-1' in UP system. This patch does a active > > >> checking to fix this issue. > > >> > > > > > > Good catch, looks fine to me. > > > > > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > > > Anyone like to pick up this build warning fix? Or comments are appreciated! > > My fault, sorry, forgot about it... > > Acked-by: Pawel Moll <pawel.moll@arm.com> > > Arnd, Olof, could you please queue it as a fix? Happy to push a branch > if you wish.
Applied. In the future, please feel free to just resend the patch with the acked-bys added, no need to send a pull request for a single patch. It's slightly more convenient to get a fresh copy of the patch into arm@kernel.org folders, since now I had to go hunt it down on the list it was originally posted.
-Olof
| |