lkml.org 
[lkml]   [2014]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] mm/balloon_compaction: general cleanup
On Fri, Aug 29, 2014 at 02:05:21PM -0700, Andrew Morton wrote:
> On Wed, 20 Aug 2014 19:05:09 +0400 Konstantin Khlebnikov <k.khlebnikov@samsung.com> wrote:
>
> > * move special branch for balloon migraion into migrate_pages
> > * remove special mapping for balloon and its flag AS_BALLOON_MAP
> > * embed struct balloon_dev_info into struct virtio_balloon
> > * cleanup balloon_page_dequeue, kill balloon_page_free
> >
>
> grump.
>
> diff -puN include/linux/balloon_compaction.h~mm-balloon_compaction-general-cleanup-fix include/linux/balloon_compaction.h
> --- a/include/linux/balloon_compaction.h~mm-balloon_compaction-general-cleanup-fix
> +++ a/include/linux/balloon_compaction.h
> @@ -145,7 +145,7 @@ static inline void
> balloon_page_insert(struct balloon_dev_info *balloon, struct page *page)
> {
> __SetPageBalloon(page);
> - list_add(&page->lru, head);
> + list_add(&page->lru, &balloon->pages);
> }
>
> static inline void balloon_page_delete(struct page *page, bool isolated)
>
>
> This obviously wasn't tested with CONFIG_BALLOON_COMPACTION=n. Please
> complete the testing of this patchset and let us know the result?
>

That also reminds me why I suggested moving those as static inlines into mm.h,
instead of getting them hidden in mm/balloon_compaction.c

Cheers,
-- Rafael


\
 
 \ /
  Last update: 2014-08-29 23:21    [W:0.066 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site