lkml.org 
[lkml]   [2014]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] Fix a bidirectional UDS connect check typo
Date
The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
bidirectional check that should have checked for mutual WRITE access
between two labels. Due to a typo the second check was incorrect.

Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
---
security/smack/smack_lsm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 478d99e..00443a9 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
rc = smk_bu_note("UDS connect", skp, okp->smk_known,
MAY_WRITE, rc);
if (rc == 0) {
- rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
- rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+ rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+ rc = smk_bu_note("UDS connect", okp, skp->smk_known,
MAY_WRITE, rc);
}
}
--
1.9.3


\
 
 \ /
  Last update: 2014-08-29 17:21    [W:0.069 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site