lkml.org 
[lkml]   [2014]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver
Date
On August 28, 2014 12:21, Lee Jones wrote:

> Steve, Adam,
>
> > Current code init regmap with &da9052_regmap_config for both da9052-spi and
> > da9052-i2c drivers. da9052-spi sets the read_flag_mask.
> > The same setting may be applied for da9052-i2c if da9052-spi driver is loaded
> > first because they actually use the same regmap_config setting.
> > Fix this issue by using a local variable for regmap_config in da9052-spi driver,
> > so the settings in spi driver won't impact the settings in i2c driver.
> > Also makes da9052_regmap_config const to avoid similar issue.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > Hi Adam and Steve,
> > Any chance to test this patch?
>
> ** Look here **

Lee, Axel,

This was on my to-do list but hadn't yet responded. Will try and find some time
in the next week to see if we can verify this.
\
 
 \ /
  Last update: 2014-08-28 16:21    [W:0.067 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site