lkml.org 
[lkml]   [2014]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] nfs: fix kernel warning when removing proc entry
    On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote:
    > Cong Wang <xiyou.wangcong@gmail.com> writes:
    >
    > > I saw the following kernel warning:
    >
    > Cong thanks for finding and tracking this. I was clearly asleep at the
    > switch when I was testing my fix to the nfs client code :(
    >
    > I have applied this patch and will push it to Linus after it has a
    > little bit to sit in linux-next.

    Why does that code wank with one-by-one remove_proc_entry(), BTW?
    remove_proc_subtree("nfsfs", net->proc_net) will take care of the whole pile
    just fine, TYVM... While we are it, there's no need to keep ->proc_nfsfs
    at all - just have it in a local variable in nfs_fs_proc_net_init().


    \
     
     \ /
      Last update: 2014-08-28 04:01    [W:4.982 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site